Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #51

Open
code423n4 opened this issue Mar 9, 2022 · 1 comment
Open

QA Report #51

code423n4 opened this issue Mar 9, 2022 · 1 comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

[L] Tokens with fee on transfer are not supported

There are ERC20 tokens that charge fee for every transfer() or transferFrom().

In the current implementation, CrossAnchorBridge.sol#handleToken() assumes that the received amount is the same as the transfer amount. This means tokens with fee on transfer are not supported.

https://github.com/code-423n4/2022-02-anchor/blob/7af353e3234837979a19ddc8093dc9ad3c63ab6b/contracts/cross-chain-contracts/ethereum/CrossAnchorBridge.sol#L177-L212

Recommendation

Make sure tokens with fee-on-transfer do not get whitelisted.
@code423n4 code423n4 added QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax bug Something isn't working labels Mar 9, 2022
code423n4 added a commit that referenced this issue Mar 9, 2022
@code423n4
WatchPug issue #51
60e5466
@GalloDaSballo
Copy link
Collaborator

Dup of #68

@GalloDaSballo GalloDaSballo added the duplicate This issue or pull request already exists label Aug 4, 2022
@JeeberC4 JeeberC4 removed the duplicate This issue or pull request already exists label Sep 21, 2022
@JeeberC4 JeeberC4 reopened this Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GalloDaSballo @code423n4 @JeeberC4