Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seems to be an inattention error #18

Closed
code423n4 opened this issue Feb 18, 2022 · 2 comments
Closed

Seems to be an inattention error #18

code423n4 opened this issue Feb 18, 2022 · 2 comments
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working duplicate This issue or pull request already exists resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Lines of code

https://github.com/Rari-Capital/solmate/blob/1205a9067ff957ef8b0b003ff9d77c20ef9f2e0b/src/mixins/ERC4626.sol#L67

Vulnerability details

Shouldn't it be _mint(to, shares); ?

Currently the using mint , one would receive as many shares as assets they transfer, which is not the intended behaviour
@code423n4 code423n4 added 3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working labels Feb 18, 2022
code423n4 added a commit that referenced this issue Feb 18, 2022
@code423n4
Picodes issue #18
ea22530
@Joeysantoro Joeysantoro added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Feb 24, 2022
This was referenced Feb 24, 2022
Closed
Closed
Open
Closed
Closed
@Joeysantoro Joeysantoro added the resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) label Feb 26, 2022
@Joeysantoro
Copy link
Collaborator

transmissions11/solmate@fd67739 fixed

@GalloDaSballo
Copy link
Collaborator

GalloDaSballo commented Mar 7, 2022 •
edited
Loading

Duplicate of #27

@GalloDaSballo GalloDaSballo marked this as a duplicate of #20 Mar 7, 2022
@GalloDaSballo GalloDaSballo added the duplicate This issue or pull request already exists label Mar 7, 2022
@GalloDaSballo GalloDaSballo marked this as a duplicate of #27 Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working duplicate This issue or pull request already exists resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GalloDaSballo @Joeysantoro @code423n4