Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #41

Open
code423n4 opened this issue Mar 15, 2022 · 0 comments
Open

Gas Optimizations #41

code423n4 opened this issue Mar 15, 2022 · 0 comments
Labels
bug Something isn't working G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Description

Unmodified memory variables were found.

Permalinks

  1. https://github.com/code-423n4/2022-03-biconomy/blob/db8a1fdddd02e8cc209a4c73ffbb3de210e4a81a/contracts/hyphen/LiquidityPool.sol#L199
  2. https://github.com/code-423n4/2022-03-biconomy/blob/db8a1fdddd02e8cc209a4c73ffbb3de210e4a81a/contracts/hyphen/LiquidityPool.sol#L223

Mitigation

Those variables can be marked as calldata instead if there is no need to modify them, saving gas costs.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Mar 15, 2022
code423n4 added a commit that referenced this issue Mar 15, 2022
@code423n4
Kenshin issue #41
63f1d0d
@pauliax pauliax mentioned this issue May 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@code423n4