Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #23

Open
code423n4 opened this issue Apr 2, 2022 · 1 comment
Open

Gas Optimizations #23

code423n4 opened this issue Apr 2, 2022 · 1 comment
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Use private variables to save gas

Currently many constants (including WEEK , MONTH and more) are declared as public. declaring those internally used constants as private for gas savings (since public variables will create view functions).

Proof of Concept

https://github.com/code-423n4/2022-03-paladin/blob/main/contracts/HolyPaladinToken.sol#L16-L42

Recommendation

Declare variables that don't need to be queried by other contracts as private.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Apr 2, 2022
code423n4 added a commit that referenced this issue Apr 2, 2022
@code423n4
rayn issue #23
157d099
@Kogaroshi
Copy link
Collaborator

QA & gas optimizations changes are done in the PR: PaladinFinance/Paladin-Tokenomics#6
(some changes/tips were implemented, others are noted but won't be applied)

@Kogaroshi Kogaroshi added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kogaroshi @code423n4