Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas Optimizations #11

Open
code423n4 opened this issue Mar 17, 2022 · 3 comments
Open

Gas Optimizations #11

code423n4 opened this issue Mar 17, 2022 · 3 comments
Labels
bug Something isn't working G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

https://github.com/code-423n4/2022-03-prepo/blob/main/contracts/core/AccountAccessController.sol#L15

constructor() {} unused and should be removed.
Doing so will improve readability and save some gas.

@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Mar 17, 2022
code423n4 added a commit that referenced this issue Mar 17, 2022
@ramenforbreakfast
Copy link
Collaborator

duplicate of #5 , also does not provide gas savings.

@ramenforbreakfast ramenforbreakfast added the duplicate This issue or pull request already exists label Mar 22, 2022
@gzeoneth gzeoneth removed the duplicate This issue or pull request already exists label Apr 3, 2022
@ramenforbreakfast
Copy link
Collaborator

ramenforbreakfast commented Apr 13, 2022

@gzeoneth I am not sure why the duplicate label was removed here?
This is mentioned exactly in #5 under Unnecessary Constructor.

Also this would make it an abstract contract which is not our intention.

@gzeoneth
Copy link
Member

@ramenforbreakfast removing the duplicate tag is simply because how C4 score gas optimization reports. There are no duplicate concept as each of them will get a individual score.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization)
Projects
None yet
Development

No branches or pull requests

3 participants