QA Report

[code423n4]

1. Comment was not same as actual code

https://github.com/code-423n4/2022-04-backd/blob/c856714a50437cb33240a5964b63687c9876275b/backd/contracts/pool/LiquidityPool.sol#L323

the current implementation was set return true, so it has not the same as comment do. cause it was return true if address of the new staker vault for the pool was correct.

##Tool Used
Manual Review

##Recommended Mitigation
Change it or remove it

##Another Occurances

1.StakerVault
2.TopUpKeeperHelper

2. Missbehavior isShutdown in shutdown()

Since isShutdown was return value false, it would be missbehavior executed after. cause return was false. This implementation usually or common use using logical operator ! for isShutdown below can be set for good or you can set it into modifier for is it done or not.

##Tool Used
Manual Review

##POC
Using this logic
https://www.tabnine.com/code/java/methods/io.netty.util.concurrent.EventExecutor/isShutdown

##Recommended Mitigation
function shutdown() external override onlyVault returns (bool) {
if (!isShutdown) return false;
isShutdown = true;
emit Shutdown();
return true;
}

or you can using this logic :

contract Shutdownable is Ownable {
bool public isShutdown;

event Shutdown();

modifier notShutdown {
    require(!isShutdown, "Smart contract is shut down.");
    _;
}

function shutdown() public onlyOwner {
    isShutdown = true;
    emit Shutdown();
}

}