Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Slippage Protection #3

Closed
code423n4 opened this issue Apr 6, 2022 · 1 comment
Closed

Missing Slippage Protection #3

code423n4 opened this issue Apr 6, 2022 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2022-04-dualityfocus/blob/f21ef7708c9335ee1996142e2581cb8714a525c9/contracts/compound_rari_fork/external/UniV3LpVault.sol

Vulnerability details

Missing slipage protection may lead to losing assets while swapping them. Without slipage protection the swapper is allowed to give much less worth of target tokens than it should in a fair swap.
to Missing slippage protection at:

    no slippage protection at _swap at UniV3LpVault.sol at line 626
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Apr 6, 2022
code423n4 added a commit that referenced this issue Apr 6, 2022
@code423n4
robee issue #3
5f5ad71
@0xdramaone 0xdramaone added the duplicate This issue or pull request already exists label Apr 11, 2022
@0xdramaone
Copy link
Collaborator

Duplicate of #42

@0xdramaone 0xdramaone marked this as a duplicate of #42 Apr 11, 2022
@JeeberC4 JeeberC4 added QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax and removed 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value labels Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@code423n4 @0xdramaone @JeeberC4