Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas Optimizations #18

Closed
code423n4 opened this issue Apr 29, 2022 · 2 comments
Closed

Gas Optimizations #18

code423n4 opened this issue Apr 29, 2022 · 2 comments
Assignees
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

No need to use safeMath, also tou could do an unchecked operation

https://github.com/pooltogether/aave-v3-yield-source/blob/e63d1b0e396a5bce89f093630c282ca1c6627e44/contracts/AaveV3YieldSource.sol#L262-L263

Consider change it to;

    uint256 _balanceDiff = _afterBalance - _beforeBalance;
    _assetToken.safeTransfer(msg.sender, _balanceDiff);

Or:

    _assetToken.safeTransfer(msg.sender, _afterBalance - _beforeBalance);

Also since _beforeBalance is always equal or less than _afterBalance we could do;

    unckecked {
        _assetToken.safeTransfer(msg.sender, _afterBalance - _beforeBalance);
    }
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Apr 29, 2022
code423n4 added a commit that referenced this issue Apr 29, 2022
@PierrickGT PierrickGT self-assigned this May 2, 2022
@PierrickGT PierrickGT added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label May 2, 2022
@PierrickGT
Copy link
Member

@gititGoro
Copy link
Collaborator

Duplicate of #15

@gititGoro gititGoro marked this as a duplicate of #15 May 12, 2022
@gititGoro gititGoro added the duplicate This issue or pull request already exists label May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Development

No branches or pull requests

3 participants