New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #333

Open

code423n4 opened this issue May 25, 2022 · 0 comments

Labels

bug G (Gas Optimization)

Contributor

code423n4 commented May 25, 2022

gas1:

prefer prefix ++i instead of suffix, no need to init i, better if used unchecked
https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/contracts/AuraClaimZap.sol#L143-L153

https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/contracts/AuraLocker.sol#L174-L175
https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/contracts/AuraVestedEscrow.sol#L100-L101

gas2:

pragma >0.8 don't need safemath

gas3:

mark functions payable with onlyOwner modifier

gas4:

lack of zero address checks
https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/contracts/AuraStakingProxy.sol#L88-L94

code423n4 added bug G (Gas Optimization) labels

code423n4 added a commit that referenced this issue


          0v3rf10w issue #333

4c877d2

0xMaharishi added the duplicate label

dmvt removed the duplicate label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment