Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #116

Open
code423n4 opened this issue May 9, 2022 · 3 comments
Open

QA Report #116

code423n4 opened this issue May 9, 2022 · 3 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2022-05-cudos/blob/main/solidity/contracts/Gravity.sol#L661

Vulnerability details

use safe math or change solidity version to 8
@code423n4 code423n4 added 3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working labels May 9, 2022
code423n4 added a commit that referenced this issue May 9, 2022
@code423n4
AmitN issue #116
b479e58
@V-Staykov
Copy link
Collaborator

Duplicate of #39

@V-Staykov V-Staykov marked this as a duplicate of #39 May 11, 2022
@V-Staykov V-Staykov added the duplicate This issue or pull request already exists label May 11, 2022
@albertchon
Copy link
Collaborator

As per the comment on #39

because the cumulative power of all the validators is calculated proportionally and made sure on the cosmos module side that it will never overflow

Hence this is not a risk.

@albertchon albertchon added QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax and removed 3 (High Risk) Assets can be stolen/lost/compromised directly labels May 18, 2022
@JeeberC4
Copy link

Creating this as warden's QA Report as judge downgraded issue. Preserving original title: addition can overflow in the constructor

@JeeberC4 JeeberC4 changed the title addition can overflow in the constructor QA Report May 19, 2022
@JeeberC4 JeeberC4 removed the duplicate This issue or pull request already exists label May 19, 2022
@JeeberC4 JeeberC4 reopened this May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@albertchon @mlukanova @V-Staykov @code423n4 @JeeberC4