Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas Optimizations #92

Open
code423n4 opened this issue May 9, 2022 · 0 comments
Open

Gas Optimizations #92

code423n4 opened this issue May 9, 2022 · 0 comments
Labels
bug Something isn't working G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Optimization #1 - These variables can be set to immutable

These variables are only able to be set in the constructor. Making them immutable will save gas when reading.

https://github.com/code-423n4/2022-05-cudos/blob/de39cf3cd1f1e1cf211819b06d4acf6a043acda0/solidity/contracts/Gravity.sol#L59-L61

Optimization #2 - This variable can be set to CONSTANT

https://github.com/code-423n4/2022-05-cudos/blob/de39cf3cd1f1e1cf211819b06d4acf6a043acda0/solidity/contracts/CosmosToken.sol#L5

Optimization #3 - For loop optimization

All for loops found in gravity.sol can be optimized by incrementing i within unchecked{}. The new pattern would be:

    for (uint i = 0; i < length;) {
        doStuff();
        unchecked {
            ++i;
        }
    }

https://github.com/code-423n4/2022-05-cudos/blob/de39cf3cd1f1e1cf211819b06d4acf6a043acda0/solidity/contracts/Gravity.sol#L453-L456

@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels May 9, 2022
code423n4 added a commit that referenced this issue May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization)
Projects
None yet
Development

No branches or pull requests

1 participant