Gas Optimizations

[code423n4]

Wrap transfer ERC20 transaction into require

https://github.com/code-423n4/2022-05-factorydao/blob/db415804c06143d8af6880bc4cda7222e5463c0e/contracts/PermissionlessBasicPoolFactory.sol#L198

https://github.com/code-423n4/2022-05-factorydao/blob/db415804c06143d8af6880bc4cda7222e5463c0e/contracts/PermissionlessBasicPoolFactory.sol#L230

https://github.com/code-423n4/2022-05-factorydao/blob/db415804c06143d8af6880bc4cda7222e5463c0e/contracts/PermissionlessBasicPoolFactory.sol#L233

https://github.com/code-423n4/2022-05-factorydao/blob/db415804c06143d8af6880bc4cda7222e5463c0e/contracts/PermissionlessBasicPoolFactory.sol#L252

https://github.com/code-423n4/2022-05-factorydao/blob/db415804c06143d8af6880bc4cda7222e5463c0e/contracts/PermissionlessBasicPoolFactory.sol#L269

https://github.com/code-423n4/2022-05-factorydao/blob/db415804c06143d8af6880bc4cda7222e5463c0e/contracts/PermissionlessBasicPoolFactory.sol#L144

• removing a bool success will save some gas and best practice is to wrap transfer ERC20 transactions to require directly.

Use

require(IERC20(pool.depositToken).transferFrom(msg.sender, address(this), amount), 'Token transfer failed');

Instead of

bool success = IERC20(pool.depositToken).transferFrom(msg.sender, address(this), amount);
require(success, 'Token transfer failed');

Remove unnecessary uint tax

https://github.com/code-423n4/2022-05-factorydao/blob/db415804c06143d8af6880bc4cda7222e5463c0e/contracts/PermissionlessBasicPoolFactory.sol#L266-L270

Use

success = success && IERC20(pool.rewardTokens[i]).transfer(globalBeneficiary,  taxes[poolId][i]);
taxes[poolId][i] = 0;

Instead of

uint tax = taxes[poolId][i];
taxes[poolId][i] = 0;
success = success && IERC20(pool.rewardTokens[i]).transfer(globalBeneficiary, tax);

[illuzen]

all duplicates

[gititGoro]

For the uint tax item, the developer is intentionally avoiding a reentrancy threat by ordering the state updates in this manner. That item is therefore invalid.