Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #17

Open
code423n4 opened this issue May 22, 2022 · 1 comment
Open

Gas Optimizations #17

code423n4 opened this issue May 22, 2022 · 1 comment
Labels
bug Something isn't working G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

createConduit used to check the existence of conduit
As the storage at _conduits[conduit] is anyways updated in future it is better to use _conduits[conduit].key == bytes32(0) and this will give a gas saving an average of 2500
https://github.com/code-423n4/2022-05-opensea-seaport/blob/7c082637d9273deb42e551c74a578151cefd8448/contracts/conduit/ConduitController.sol#L85
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels May 22, 2022
code423n4 added a commit that referenced this issue May 22, 2022
@code423n4
ignacio issue #17
8758cbd
@0xleastwood 0xleastwood added the invalid This doesn't seem right label Jun 23, 2022
@HardlyDifficult HardlyDifficult removed the invalid This doesn't seem right label Jul 4, 2022
@code-423n4 code-423n4 deleted a comment from 0xleastwood Jul 4, 2022
@HardlyDifficult
Copy link
Collaborator

Savings confirmed, and it seems to accomplish the same goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@HardlyDifficult @0xleastwood @code423n4