Wrong DOMAIN_SEPERATOR calculation in initialize() of BathToken because of using uninitialized name

[code423n4]

Lines of code

https://github.com/code-423n4/2022-05-rubicon/blob/8c312a63a91193c6a192a9aab44ff980fbfd7741/contracts/rubiconPools/BathToken.sol#L195-L210

Vulnerability details

Impact

DOMAIN_SEPERATOR were calculated with wrong values (name value set after using it), so all the logics based on DOMAIN_SEPERATOR is not going to work properly.

Proof of Concept

This is where code calculates DOMAIN_SEPERATOR:

        uint256 chainId;
        assembly {
            chainId := chainid()
        }
        DOMAIN_SEPARATOR = keccak256(
            abi.encode(
                keccak256(
                    "EIP712Domain(string name,string version,uint256 chainId,address verifyingContract)"
                ),
                keccak256(bytes(name)),
                keccak256(bytes("1")),
                chainId,
                address(this)
            )
        );
        name = string(abi.encodePacked(_symbol, (" v1")));

As you can see the value of name has been set after using it in DOMAIN_SEPARATOR calculation.

Tools Used

VIM

Recommended Mitigation Steps

set name value before using it

[bghughes]

Duplicate of #38