New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QA Report #13
Labels
bug
Something isn't working
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Comments
code423n4
added
bug
Something isn't working
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
labels
May 25, 2022
[1] IF nesting could be reduced by having early return/continue.Valid NC [2] Multiple divisions can degradate precision.Disagree because they are used for floor math [3] Token decimals is a constant parameter that never changes.Finding is invalid [4] By default, function types and state variables/constants are internal, so the internal keyword can be omitted.This is against best practices [5] Magic number, consider using named constant instead.Valid NC [6] Consider using "_" separate digit capacity i.e "100000" could be replaced to "100_000".Valid NC [7] Consider using IERC20 type instead of address.Disagree as it's just opinion [8] Uint8-256 / Int8-256 is assigned to zero by default, additional reassignment to zero is unnecessary.Valid NC [9] It is recommended to explicitly specify uint256 type instead of uint type for better readability.What were you thinking to paste 675 links??? Very soulles report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Please paste contents of this file. It exceeds the limit.
https://software.valar-solutions.com/Hosting/screenshots/2022-05-25_16-14-59.md
The text was updated successfully, but these errors were encountered: