QA Report #265
Labels
bug
Something isn't working
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
[L-01] Immutable addresses should 0-Check
I recommend adding check of 0-address for immutable addresses.
Not doing so might lead to non-functional contract when it is updated to 0-address accidentally.
Issue found at
[L-02] abi.encodePacked should not be used with dynamic types
This is because using abi.encodePacked with dynamic types will cause a hash collisions.
link: https://docs.soliditylang.org/en/v0.8.13/abi-spec.html#non-standard-packed-mode
I recommend using abi.encode instead.
[N-01] Event is missing indexed fields
Each event should have 3 indexed fields if there are 3 or more fields.
Issue found at
[N-02] Unnecessary use of named returns
Several function adds return statement even thought named returns variable are used.
Remove unnecessary named returns variable to improve code readability.
Also keeping the use of named returns or return statement consistent through out the whole project if possible is recommended.
Issue found at
InfinityToken.sol
[N-03] Large Multiples of Ten should use Scientific Notation
Large multiples of ten is hard to read so use scientific notation instead for readability.
Issue found at
The text was updated successfully, but these errors were encountered: