QA Report

[code423n4]

Summary

Risk	Title
L00	Usage of transfer to send eth
L01	Lack of zero address check
L02	Incomplete NatSpec

Low

L00: Usage of transfer to send eth

The transfer function has a fixed gas stipend of 2300. If a contract as well as EOA can call the function, it is advised to use call function instead of transfer.

Here are transfer function used in the ETHRegistrarController.sol:

• https://github.com/code-423n4/2022-07-ens/blob/ff6e59b9415d0ead7daf31c2ed06e86d9061ae22/contracts/ethregistrar/ETHRegistrarController.sol#L183-L185
• https://github.com/code-423n4/2022-07-ens/blob/ff6e59b9415d0ead7daf31c2ed06e86d9061ae22/contracts/ethregistrar/ETHRegistrarController.sol#L203-L205
• https://github.com/code-423n4/2022-07-ens/blob/ff6e59b9415d0ead7daf31c2ed06e86d9061ae22/contracts/ethregistrar/ETHRegistrarController.sol#L183-L185
• https://github.com/code-423n4/2022-07-ens/blob/ff6e59b9415d0ead7daf31c2ed06e86d9061ae22/contracts/ethregistrar/ETHRegistrarController.sol#L210-L212

L01: Lack of zero address check

Functions without checks on the zero address may cause loss of token

• NameWrapper::onERC721Received
  • the newly minted ERC1155 wrap can be transferred to zero address
• NameWrapper::setRecord
  • the token can be transferred to zero address

L02: Mismatching NatSpec

file	line	function	note	link
DNSSECImpl.sol	108	validateSignedSet	missing return value in NatSpec	https://github.com/code-423n4/2022-07-ens/blob/ff6e59b9415d0ead7daf31c2ed06e86d9061ae22/contracts/dnssec-oracle/DNSSECImpl.sol#L108-L109
DNSSECImpl.sol	145	validateRRs	missing return value in NatSpec	https://github.com/code-423n4/2022-07-ens/blob/ff6e59b9415d0ead7daf31c2ed06e86d9061ae22/contracts/dnssec-oracle/DNSSECImpl.sol#L145-L146
NameWrapper.sol	114	uri	missing param in NatSpec	https://github.com/code-423n4/2022-07-ens/blob/ff6e59b9415d0ead7daf31c2ed06e86d9061ae22/contracts/wrapper/NameWrapper.sol#L113-L114
ReverseRegistrar.sol	73	claimForAddr	missing param in NatSpec	https://github.com/code-423n4/2022-07-ens/blob/ff6e59b9415d0ead7daf31c2ed06e86d9061ae22/contracts/registry/ReverseRegistrar.sol#L72-L73