QA Report

[code423n4]

Summary

We list 2 low-critical findings:

• (Low) floating pragma
• (Low) Open TODO

(Low) floating pragma

Impact

Floating pragma may cause unexpected compilation time behaviour and introduce unintended bugs.

Proof of Concept

dnssec-oracle/BytesUtils.sol
1:pragma solidity ^0.8.4;

dnssec-oracle/SHA1.sol
1:pragma solidity >=0.8.4;

dnssec-oracle/DNSSECImpl.sol
2:pragma solidity ^0.8.4;

dnssec-oracle/DNSSEC.sol
2:pragma solidity ^0.8.4;

dnssec-oracle/RRUtils.sol
1:pragma solidity ^0.8.4;

Recommended Mitigation Steps

Don't use ^, lock pragma to ensure compiler version. e.g. pragma solidity 0.8.4;

(Low) Open TODO

Impact

Open TODO should be resolved.

Proof of Concept

https://github.com/code-423n4/2022-07-ens/blob/main/contracts/dnssec-oracle/DNSSECImpl.sol#L238

        // TODO: Check key isn't expired, unless updating key itself

Recommended Mitigation Steps

Resolve the TODO.