Use safeTransfer and safeTransferFrom from SafeERC20
#229
Labels
bug
Warden finding
duplicate
Another warden found this issue
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Lines of code
https://github.com/code-423n4/2022-07-fractional/blob/main/src/modules/protoforms/BaseVault.sol#L65
https://github.com/code-423n4/2022-07-fractional/blob/main/src/references/TransferReference.sol#L22
Vulnerability details
Impact
Some tokens fail silently, not throwing an error. The functions
safeTransfer
andsafeTransferFrom
has checks for that returns and throw an error if not possible to transfer the tokensRecommended Mitigation Steps
The text was updated successfully, but these errors were encountered: