QA Report #679
Labels
bug
Something isn't working
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
1. Contract
rewards/RewardDistributor.sol
[LOW] ignores return value in
rewardToken.transfer(...)
File(s):
rewards/RewardDistributor.sol
Description: The public functions
traderClaim(...)
,exchangeClaim(..)
,multiStakerClaim(...)
making a transfer call and does not check for return value if the transfer is a success or fails.Recommendation: always check for return value, as in some cases call may return false instead of reverting.
2. Contract
core/GolomTrader.sol
[Informational] performing multiplication on result of division in function
fill_ask(...)
File(s): 'core/GolomTrader.sol`
Description: The function
fill_ask(...)
is performing multiplication on result of division and it may sometimes lead to loss of precision.Recommendation: refactor the statement.
[Informational] Missing address(0) check in function
setMinter(...)
File(s): https://github.com/code-423n4/2022-07-golom/blob/e5efa8f9d6dda92a90b8b2c4902320acf0c26816/contracts/governance/GolomToken.sol#L58
Description: In function
setMinter(...)
there is missing input address(0) validation.Recommendation: Consider performing zero-address validation before setting the pendingMinter.
3. Contract
vote-escrow/VoteEscrowDelegation.sol
[Informational] wrong datatype of argument in function signature definition in
Interface IVoteEscrow
File(s):
vote-escrow/VoteEscrowDelegation.sol
Description: The function definition of
balanceOf(...)
inside an Interface IVoteEscrow is passing 'uint256' datatype of argument in place of address. The code is shown below.Recommendation: consider passing the correct datatype of arguments during the function definition.
The text was updated successfully, but these errors were encountered: