Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #205

Open
code423n4 opened this issue Jul 8, 2022 · 0 comments
Open

QA Report #205

code423n4 opened this issue Jul 8, 2022 · 0 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax valid

Comments

@code423n4
Copy link
Contributor

Incentive to contribute late, after overflow

If the funding target is not met, the fund is not redeemable. However, after the funding target is hit, new contribution will have an advantage of redeemable, compare to early pay.

Suggestion:
Distinguish between redemption before and after funding target.

Constant discount rate for long going funding cycles will damper user's incentive to contribute

For any discount rate > 0, and multiple periodic funding cycle, the token received per ETH/USDC contribution would exponentially going to 0, makes the project less and less attractive to users. And eventually not worth contributing anymore.
For example, 0.9^20 = 0.12, 0.95^40 = 0.36, for discount rate of 10%, after 20 cycles, the token is only 12%, for discount rate of 5%, only 36% left. Keep in mind they it is exponentially decrease.

If a project is configured by a contract, not being able to change, the later stages of the project could be hard to develop.

Suggestion:
Creating alert for long going projects, or contract owned projects.

Reconfiguration can not be cancelled

There is a delay in the reconfiguration, but after submit, it can not be cancelled.
Sometimes project operators may make mistakes, or change their mind after community discussion.

Suggestion:
Allowing for cancellation for pending reconfiguration.

redemption rate should be > 0

If the redemption rate is set to 0, it is equivalent to not allow redemption, which can be set elsewhere.

Suggestion:
Enforce the redemption rate > 0

@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Jul 8, 2022
code423n4 added a commit that referenced this issue Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax valid
Projects
None yet
Development

No branches or pull requests

2 participants