Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #284

Open
code423n4 opened this issue Jul 8, 2022 · 0 comments
Open

QA Report #284

code423n4 opened this issue Jul 8, 2022 · 0 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax valid

Comments

@code423n4
Copy link
Contributor

1. Add address(0) check while setting new addresses

It is recommended to check for zero address to save from unintentional consequences.

2. Unused import

IJBFundingCycleStore.sol is imported but not used insde the interface.

3. Large multiples of ten should use scientific notation (e.g. 1e9) rather than decimal literals (e.g. 1000000000), for readability
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Jul 8, 2022
code423n4 added a commit that referenced this issue Jul 8, 2022
@code423n4
0xf15ers issue #284
4559623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax valid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@code423n4 @jack-the-pug