Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No check for zero address while updating owner #83

Open
code423n4 opened this issue Jul 15, 2022 · 3 comments
Open

No check for zero address while updating owner #83

code423n4 opened this issue Jul 15, 2022 · 3 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue wontfix out of scope, a non-issue, or something already addressed

Comments

@code423n4
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2022-07-ens/blob/main/contracts/dnssec-oracle/Owned.sol#L19

Vulnerability details

Impact

No check for zero address, allows somebody to set owner as zero-address, this will make the DNSSECImpl contract unusable.

Proof of Concept

https://github.com/code-423n4/2022-07-ens/blob/main/contracts/dnssec-oracle/Owned.sol#L19

Tools Used

Manual

Recommended Mitigation Steps

require(newOwner!=address(0));
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Jul 15, 2022
code423n4 added a commit that referenced this issue Jul 15, 2022
@code423n4
rishabh issue #83
1e104f6
@JTraversa JTraversa added the sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue label Jul 19, 2022
@JTraversa
Copy link
Collaborator

https://github.com/code-423n4/2022-07-swivel#input-sanitization

@bghughes
Copy link
Collaborator

bghughes commented Aug 3, 2022

https://github.com/code-423n4/2022-07-swivel#input-sanitization

Agreed, downgrading to QA.

@bghughes bghughes added QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax and removed 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value labels Aug 3, 2022
@bghughes
Copy link
Collaborator

bghughes commented Aug 3, 2022

This warden did not submit a QA report so this will act as their QA report

@robrobbins robrobbins added duplicate This issue or pull request already exists wontfix out of scope, a non-issue, or something already addressed labels Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue wontfix out of scope, a non-issue, or something already addressed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@robrobbins @bghughes @JTraversa @code423n4