Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #94

Open
code423n4 opened this issue Jul 15, 2022 · 1 comment
Open

QA Report #94

code423n4 opened this issue Jul 15, 2022 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax wontfix out of scope, a non-issue, or something already addressed

Comments

@code423n4
Copy link
Contributor

[L01] Add 2 step Changes for Critical Changes

Critical changes such as ownership updates should be a 2 step process to protect against human error. While the errors are unlikely important parts of the contract would become unusable if they occured.
Consider changing the following functions to 2 step procedures.
Swivel.sol#L428
MarketPlace.sol#L53
Creator.sol#L47

[L02] Unlocked Pragma

Recommend not using a floating pragma and changing to 0.8.13 to be consistent with other contracts.
ZcToken.sol#L2

[N01] Open Todos

There are 17 open todos throughout swivel.sol, recommend resolving and removing before deployment.
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Jul 15, 2022
code423n4 added a commit that referenced this issue Jul 15, 2022
@code423n4
_Adam issue #94
b9cbe64
@robrobbins
Copy link
Collaborator

addressed elsewhere

@robrobbins robrobbins added duplicate This issue or pull request already exists wontfix out of scope, a non-issue, or something already addressed labels Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax wontfix out of scope, a non-issue, or something already addressed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robrobbins @code423n4