New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #137

Open

code423n4 opened this issue Aug 15, 2022 · 0 comments

Labels

bug G (Gas Optimization)

Contributor

code423n4 commented Aug 15, 2022

https://github.com/code-423n4/2022-08-fiatdao/blob/fece3bdb79ccacb501099c24b60312cd0b2e4bb2/contracts/features/Blocklist.sol#L33
function isBlocked(address addr) public view returns (bool) should be external instead of public

https://github.com/code-423n4/2022-08-fiatdao/blob/fece3bdb79ccacb501099c24b60312cd0b2e4bb2/contracts/VotingEscrow.sol#L57
Point[1000000000000000000] is a very big array, it should be considered to reduce size in order to save gas

https://github.com/code-423n4/2022-08-fiatdao/blob/fece3bdb79ccacb501099c24b60312cd0b2e4bb2/contracts/VotingEscrow.sol#L412
These requirements could be changed with custom errors in order to save gas. https://blog.soliditylang.org/2021/04/21/custom-errors/

code423n4 added bug G (Gas Optimization) labels

code423n4 added a commit that referenced this issue


          PaludoX0 issue #137

d3aa196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment