QA Report

[code423n4]

Summary

Non-critical Issues

	Issue	Instances
1	Useless variables, redundant code	1

Total: 1 instances over 1 issues

Non-critical Issues

Useless variables, redundant code

Since uEpoch == 0 in the condition of the if statement, the [uEpoch + 1] = [0+1] = [1], uEpoch in userPointHistory[_addr][uEpoch + 1] = userOldPoint is meaningless and can be written as userPointHistory[_addr][1] = userOldPoint.

File: contracts/VotingEscrow.sol #1 

257:    if (uEpoch == 0) {
258:         userPointHistory[_addr][uEpoch + 1] = userOldPoint;        
259:    }

https://github.com/code-423n4/2022-08-fiatdao/blob/fece3bdb79ccacb501099c24b60312cd0b2e4bb2/contracts/VotingEscrow.sol#L257-L259

[gititGoro]

Duplicate of #152