Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #323

Open
code423n4 opened this issue Sep 1, 2022 · 0 comments
Open

Gas Optimizations #323

code423n4 opened this issue Sep 1, 2022 · 0 comments
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

code423n4 commented Sep 1, 2022 •
edited

INFORMATIONAL SEVERITY ISSUES

Change Function Visibilities

Description:
Some functions in the contract are designed with a public function without being called internally within the contract. These sets of function with the public visibility costs will cost more call during interaction. The function shares the same name across modules.

The functions are:
KEYCODE
VERSION

Remediation:
For gas optimization, it’s recommended to make these functions external since they were not directly used within the contract.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Sep 1, 2022
code423n4 added a commit that referenced this issue Sep 1, 2022
@code423n4
The_GUILD issue #323
f5a3e2b
code423n4 added a commit that referenced this issue Sep 1, 2022
@code423n4
The_GUILD data for issue #323
a47c16b
@0xLienid 0xLienid added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@code423n4 @0xLienid