QA Report #353
Labels
bug
Something isn't working
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
no need for these curly brackets
{ }
Finding
https://github.com/code-423n4/2022-08-olympus/blob/main/src/modules/PRICE.sol#L160-L174
It is better to emit the
oldDebt
Finding
https://github.com/code-423n4/2022-08-olympus/blob/main/src/modules/TRSRY.sol#L134
Check for address(0)
Finding
https://github.com/code-423n4/2022-08-olympus/blob/main/src/modules/TRSRY.sol#L122-L135
https://github.com/code-423n4/2022-08-olympus/blob/main/src/policies/TreasuryCustodian.sol#L42-L48
Not the better pattern
It is better to make it as the other line above it. Like this one
_range.cushion.low.price = (movingAverage_ * (FACTOR_SCALE - cushionSpread)) / FACTOR_SCALE;
Finding
https://github.com/code-423n4/2022-08-olympus/blob/main/src/modules/RANGE.sol#L168-L170
unnecessary invoking
These two invokes don’t do anything they are keep every thing the same
But if you trying to set the capacity to zero this is no how you do it
Finding
https://github.com/code-423n4/2022-08-olympus/blob/main/src/policies/Operator.sol#L202-L203
The text was updated successfully, but these errors were encountered: