We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In the for loop in the function _setPolicyPermissions, the iterator i is initialized to 0, when by default it is zero (https://github.com/code-423n4/2022-08-olympus/blob/main/src/utils/KernelUtils.sol)
_setPolicyPermissions
i
Similarly, in KernelUtils.sol also this happpens (https://github.com/code-423n4/2022-08-olympus/blob/main/src/utils/KernelUtils.sol#L40) (https://github.com/code-423n4/2022-08-olympus/blob/main/src/utils/KernelUtils.sol#L55)
Using ++i instead of i++ can save gas
(https://github.com/code-423n4/2022-08-olympus/blob/main/src/utils/KernelUtils.sol#L49) (https://github.com/code-423n4/2022-08-olympus/blob/main/src/utils/KernelUtils.sol#L64)
The text was updated successfully, but these errors were encountered:
ne0n issue #73
1f27ca9
ne0n data for issue #73
6c57ae5
Report for issue #73 updated by ne0n
f4a3c63
No branches or pull requests
Initailizing variable that are by default initialized causes gas fees
In the for loop in the function
_setPolicyPermissions, the iteratoriis initialized to 0, when by default it is zero(https://github.com/code-423n4/2022-08-olympus/blob/main/src/utils/KernelUtils.sol)
Similarly, in KernelUtils.sol also this happpens
(https://github.com/code-423n4/2022-08-olympus/blob/main/src/utils/KernelUtils.sol#L40)
(https://github.com/code-423n4/2022-08-olympus/blob/main/src/utils/KernelUtils.sol#L55)
Using ++i instead of i++ for optimizing gas
Using ++i instead of i++ can save gas
(https://github.com/code-423n4/2022-08-olympus/blob/main/src/utils/KernelUtils.sol#L49)
(https://github.com/code-423n4/2022-08-olympus/blob/main/src/utils/KernelUtils.sol#L64)
The text was updated successfully, but these errors were encountered: