QA Report

[code423n4]

Rebasing and fee-on-transfer tokens will break accounting logic

Severity: Low

Context:

• https://github.com/code-423n4/2022-08-rigor/blob/5ab7ea84a1516cb726421ef690af5bc41029f88f/contracts/Community.sol#L757
• https://github.com/code-423n4/2022-08-rigor/blob/5ab7ea84a1516cb726421ef690af5bc41029f88f/contracts/Community.sol#L824

Description:

The accounting logic used throughout the protocol assumes that the balance of tokens will not change during the lifecycle. As such, it is important that tokens used in the protocol do not contain any rebasing, fee-on-transfer, or similar balance changing logic. Failure to use static balance tokens will result in unexpected effects including locked funds and failed transactions.

Remediation

It's recommended to take care in ensuring that tokens used in the protocol do not contain rebasing, fee-on-transfer, or similar balance changing logic.