Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #157

Open
code423n4 opened this issue Aug 6, 2022 · 0 comments
Open

QA Report #157

code423n4 opened this issue Aug 6, 2022 · 0 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax valid

Comments

@code423n4
Copy link
Contributor

1.HomeFi.sol setTrustedForwarder()
change the forwarder has a great impact, recommended to add events, good for monitoring important event

    /// @inheritdoc IHomeFi
    function setTrustedForwarder(address _newForwarder)
        external
        override
        onlyAdmin
        noChange(trustedForwarder, _newForwarder)
    {
        trustedForwarder = _newForwarder;

        ++++ emit ForwarderReplaced(_newForwarder);
    }
  1. project.currency() is not IDebtToken, it should be IERC20
    The wrong type of IDebtToken is used, which leads to confusion in understanding the logic of contract, DebtToken is not used for payment and cannot be transfer.
    Community.sol also has the same problem, suggest to change it to IERC20:
contract Project is
    IProject,
    ReentrancyGuardUpgradeable,
    ERC2771ContextUpgradeable
{
   --- using SafeERC20Upgradeable for IDebtToken;
   +++ using SafeERC20 for IERC20; 

...
...
    ---- IDebtToken public override currency;
    ++++ IERC20 public override currency;
....
}

function initialize(
    address _currency,
    address _sender,
    address _homeFiAddress
) external override initializer {
    // Initialize variables
    homeFi = IHomeFi(_homeFiAddress);
    disputes = homeFi.disputesContract();
    lenderFee = homeFi.lenderFee();
    builder = _sender;
    --- currency = IDebtToken(_currency);
    +++ currency = IERC20(_currency);
}

@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Aug 6, 2022
code423n4 added a commit that referenced this issue Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax valid
Projects
None yet
Development

No branches or pull requests

2 participants