QA Report

[code423n4]

2022-08-RIGOR

Low Risk and Non-Critical Issues

Events not emmited on important state changes

Emmiting events is recommended each time when a state variable's value is being changed or just some critical event for the contract has occurred. It also helps off-chain monitoring of the contract's state.

There are 10 instances of this issue:

File: contracts/Community.sol

102:  function initialize(address _homeFi)

https://github.com/code-423n4/2022-08-rigor/blob/b17b2a11d04289f9e927c71703b42771dd7b86a4/contracts/Community.sol

File: contracts/DebtToken.sol

43:   function initialize(

https://github.com/code-423n4/2022-08-rigor/blob/b17b2a11d04289f9e927c71703b42771dd7b86a4/contracts/DebtToken.sol

File: contracts/Disputes.sol

74:   function initialize(address _homeFi)

https://github.com/code-423n4/2022-08-rigor/blob/b17b2a11d04289f9e927c71703b42771dd7b86a4/contracts/Disputes.sol

File: contracts/HomeFi.sol

92:   function initialize(

200:  function setTrustedForwarder(address _newForwarder)

https://github.com/code-423n4/2022-08-rigor/blob/b17b2a11d04289f9e927c71703b42771dd7b86a4/contracts/HomeFi.sol

File: contracts/HomeFiProxy.sol

58:   function initiateHomeFi(address[] calldata _implementations)

https://github.com/code-423n4/2022-08-rigor/blob/b17b2a11d04289f9e927c71703b42771dd7b86a4/contracts/HomeFiProxy.sol

File: contracts/Project.sol

94:   function initialize(

543:  function getTask(uint256 id)

https://github.com/code-423n4/2022-08-rigor/blob/b17b2a11d04289f9e927c71703b42771dd7b86a4/contracts/Project.sol

File: contracts/ProjectFactory.sol

45:   function initialize(address _underlying, address _homeFi)

58:   function changeProjectImplementation(address _underlying)

https://github.com/code-423n4/2022-08-rigor/blob/b17b2a11d04289f9e927c71703b42771dd7b86a4/contracts/ProjectFactory.sol

public functions not called by the contract should be declared external instead

There are 5 instances of this issue:

File: contracts/DebtToken.sol

82:   function decimals() public view virtual override returns (uint8) {

91:   function transferFrom(

100:  function transfer(

https://github.com/code-423n4/2022-08-rigor/blob/b17b2a11d04289f9e927c71703b42771dd7b86a4/contracts/DebtToken.sol

File: contracts/HomeFi.sol

264:  function isTrustedForwarder(address _forwarder)

https://github.com/code-423n4/2022-08-rigor/blob/b17b2a11d04289f9e927c71703b42771dd7b86a4/contracts/HomeFi.sol

File: contracts/libraries/Tasks.sol

75:   function initialize(Task storage _self, uint256 _cost) public {

https://github.com/code-423n4/2022-08-rigor/blob/b17b2a11d04289f9e927c71703b42771dd7b86a4/contracts/libraries/Tasks.sol