Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #309

Open
code423n4 opened this issue Aug 6, 2022 · 0 comments
Open

QA Report #309

code423n4 opened this issue Aug 6, 2022 · 0 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax valid

Comments

@code423n4
Copy link
Contributor

L: Insufficient protection of sensitive data

The hardhat.config.ts uses sensitive information imported from an un-committed environment file. The usage of either .env imported variables or even plain pasted keys make it easier for an attacker to compromise the keys used for monitoring, deployment, testing and even if wallet private keys are used in such way funds can be compromised.

The following data could be compromised if a leak happens or if the .gitignore file is mistakenly deleted according to the imports performed on hardhat.config.ts:

const {
INFURA,
ACCOUNT_PRIVATE_KEY,
MNEMONIC,
ETHERSCAN_API_KEY,
CI,
REPORT_GAS,
COINMARKETCAP_API_KEY,
REPORT_SIZE,
REPORT_GAS_PRICE,
} = process.env;

It is advisable to use other ways of storing sensible keys such as hardware devices in order to prevent data leaks that may lead to catastrophic issues.

@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Aug 6, 2022
code423n4 added a commit that referenced this issue Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax valid
Projects
None yet
Development

No branches or pull requests

2 participants