QA Report

[code423n4]

• In porjectFactory.sol L78 function createProject is under the EXTERNAL VIEWS commentary while not beeing a view function.
• HomeFi.sol function isProjectExist naming is not correct english. doesProjectExist is better
• The function getTask in the contract Project does not take the same argument name as indicated in the interface IProject, it is id instead of _taskId.
• In Community.sol L686, consider using 1 days instead of 86400.
• In Tasks.sol L16 the mapping alerts should be of type mapping(Lifecycle => bool). Some other parts of the code would need to be modified (remove conversions to uint256).
• HomeFi.sol, function createProject L210: everyone is free to create a project with any given hash, even the hash of an already existing project. This does not cause direct issue inside the protocol, but could be the source of some troubles if other protocols base their trust on the hash of the project. Possible fix: create a mapping (hash => bool) to avoid collisons.
• In the contract Project, the function projectCost can run out of gas if there are too many tasks. It would block the functions lendToProject and toggleLendingNeeded, that are important functions. Suggested fix: update the project cost in a storage variable each time a task is added of updated.
• For the builder to repay totally a loan, he has to give exactly the amount owed, if he gives too much, the function _reduceDebt will revert. But, because the lender is gaining interests at each block, it will be very difficult for the builder to give exacly the amount owed, so the debt can be endless. Seggested fix: accept giving more value that owed, and let the function cap the amout by itslef.