Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #406

Open
code423n4 opened this issue Aug 6, 2022 · 2 comments
Open

QA Report #406

code423n4 opened this issue Aug 6, 2022 · 2 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax valid

Comments

@code423n4
Copy link
Contributor

It is best practice and also unnecessary to initialize for variables in:

Contract HomeFiProxy.sol

Line 87
Line 136

Contract Project.sol

Line 248
Line 311
Line 311

Contract Tasks.sol

Line 181

Recommendation:

for (uint256 i; i < _length; i++) throughout all for instances
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Aug 6, 2022
code423n4 added a commit that referenced this issue Aug 6, 2022
@code423n4
a12jmx issue #406
a1de4bd
@parv3213
Copy link
Collaborator

parv3213 commented Aug 7, 2022

Good QA recommendations.

@zgorizzo69
Copy link
Collaborator

duplicates of #401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax valid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zgorizzo69 @parv3213 @code423n4 @jack-the-pug