Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #129

Open
code423n4 opened this issue Sep 24, 2022 · 0 comments
Open

QA Report #129

code423n4 opened this issue Sep 24, 2022 · 0 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

code423n4 commented Sep 24, 2022

frxETHMinter.sol: depositEther function could become unusable

Link: https://github.com/code-423n4/2022-09-frax/blob/55ea6b1ef3857a277e2f47d42029bc0f3d6f9173/src/frxETHMinter.sol#L129

If large enough sum would be deposited to this contract, depositEther could become unusable, as it will run out of gas every time. Luckily, there is a governance function that could fix it by withdrawing ether, so I think this is low risk issue. But fixing it could become cumbersome and cause people to panic.
Additionaly, some bots have certain gas limits (for example, Chainlink Keepers can't run transactions with more then 1.5m gas). This could cause additional problems even sooner then depositEther will became unusable

Solution: limit numDeposit variable

@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Sep 24, 2022
code423n4 added a commit that referenced this issue Sep 24, 2022
code423n4 added a commit that referenced this issue Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Development

No branches or pull requests

1 participant