Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #111

Open
code423n4 opened this issue Sep 22, 2022 · 0 comments
Open

QA Report #111

code423n4 opened this issue Sep 22, 2022 · 0 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

code423n4 commented Sep 22, 2022 •
edited

QA

  1. Contract VariableSupplyERC20Token.sol has a variable named maxSupply, which has a different meaning than mintable supply. maxSupply's meaning is closer to mintablesupply + initialsupply, or the ceiling for totalsupply. It is better to rename it to maxMintableSupply or something similar, to make it clear that it is only counting tokens yet to be minted.
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Sep 22, 2022
code423n4 added a commit that referenced this issue Sep 22, 2022
@code423n4
carrotsmuggler issue #111
ee66084
code423n4 added a commit that referenced this issue Sep 22, 2022
@code423n4
carrotsmuggler data for issue #111
5393dec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@code423n4