Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded Q -> H from 262 [1667614992867] #518

Closed
code423n4 opened this issue Nov 5, 2022 · 1 comment
Closed

Upgraded Q -> H from 262 [1667614992867] #518

code423n4 opened this issue Nov 5, 2022 · 1 comment
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working duplicate This issue or pull request already exists partial-50 Incomplete articulation of vulnerability; eligible for partial credit only (50%) upgraded by judge Original issue severity upgraded from QA/Gas by judge

Comments

@code423n4
Copy link
Contributor

Judge has assessed an item in Issue #262 as High risk. The relevant finding follows:
@code423n4 code423n4 added 3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working upgraded by judge Original issue severity upgraded from QA/Gas by judge labels Nov 5, 2022
code423n4 added a commit that referenced this issue Nov 5, 2022
@code423n4
Upgrade for bin2chen issue #518
cdc1dc1
@HickupHH3
Copy link
Collaborator

HickupHH3 commented Nov 5, 2022 •
edited

Controller.sol
When block.timestamp = epochEnd , and latestPrice < strikePrice triggerDepeg() can pass and triggerEndEpoch() also can pass, so Keeper can choose trigger "Depeg" or "not Depeg" triggerDepeg() recommended to use >=epochEnd

dup of #69, but partial credit because of failure to explain impact.

@HickupHH3 HickupHH3 added partial-50 Incomplete articulation of vulnerability; eligible for partial credit only (50%) duplicate This issue or pull request already exists labels Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working duplicate This issue or pull request already exists partial-50 Incomplete articulation of vulnerability; eligible for partial credit only (50%) upgraded by judge Original issue severity upgraded from QA/Gas by judge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@code423n4 @HickupHH3