Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded Q -> H from 211 [1667662048262] #524

Closed
code423n4 opened this issue Nov 5, 2022 · 1 comment
Closed

Upgraded Q -> H from 211 [1667662048262] #524

code423n4 opened this issue Nov 5, 2022 · 1 comment
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working duplicate This issue or pull request already exists satisfactory satisfies C4 submission criteria; eligible for awards upgraded by judge Original issue severity upgraded from QA/Gas by judge

Comments

@code423n4
Copy link
Contributor

Judge has assessed an item in Issue #211 as High risk. The relevant finding follows:

@code423n4 code423n4 added 3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working upgraded by judge Original issue severity upgraded from QA/Gas by judge labels Nov 5, 2022
code423n4 added a commit that referenced this issue Nov 5, 2022
@HickupHH3
Copy link
Collaborator

When block.timestamp = epochEnd, both triggerDepeg and triggerEndEpoch is potentially callable, because the functions require that the timestamp is <= or >=, respectively. When the depeg happens exactly at this timestamp, there is a huge incentive for capital providers to call triggerEndEpoch, whereas the insured persons want to call triggerDepeg. It is recommended to change one of the functions to enforce a strict inequality to avoid such situations where frontrunning can be very profitable.

dup of #69

@HickupHH3 HickupHH3 added the satisfactory satisfies C4 submission criteria; eligible for awards label Nov 5, 2022
@JeeberC4 JeeberC4 added the duplicate This issue or pull request already exists label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working duplicate This issue or pull request already exists satisfactory satisfies C4 submission criteria; eligible for awards upgraded by judge Original issue severity upgraded from QA/Gas by judge
Projects
None yet
Development

No branches or pull requests

3 participants