Report for issue #194 updated by chrisdior4

code-423n4 · Oct 24, 2022 · b244908 · b244908
1 parent 826e9b7
commit b244908
Showing 1 changed file with 19 additions and 0 deletions.
diff --git a/data/chrisdior4-Q.md b/data/chrisdior4-Q.md
@@ -35,3 +35,22 @@
   }
 2.https://github.com/code-423n4/2022-10-holograph/blob/f8c2eae866280a1acfdc8a8352401ed031be1373/contracts/HolographGenesis.sol#L146
 
+
+# Code Style: constants should be named in all caps
+
+### Here are some examples that the code style does not follow the best practices: 
+
+#### File: HolographBridge.sol
+
+1.bytes32 constant _factorySlot = 0xa49f20855ba576e09d13c8041c8039fa655356ea27f6c40f1ec46a4301cd5b23;
+1.https://github.com/code-423n4/2022-10-holograph/blob/f8c2eae866280a1acfdc8a8352401ed031be1373/contracts/HolographBridge.sol#L126
+
+#### Consider changing the name to: FACTORY_SLOT
+
+
+
+#### File: HolographTreasury.sol
+2.bytes32 constant _holographSlot = 0xb4107f746e9496e8452accc7de63d1c5e14c19f510932daa04077cd49e8bd77a;
+2.https://github.com/code-423n4/2022-10-holograph/blob/f8c2eae866280a1acfdc8a8352401ed031be1373/contracts/HolographTreasury.sol#L133
+
+#### Consider changing the name to: HOLOGRAPH_SLOT