QA Report #246
Labels
bug
Something isn't working
grade-b
Q-60
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Comments
code423n4
added
bug
code423n4
added a commit
that referenced
this issue
Oct 30, 2022
|
kirk-baird marked the issue as grade-b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1) Usage of
block.timestampis risky, as it can be manipulated by miners, so avoid it.https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L237
https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L319
https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L380
https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L426
2) Missing 0-address check
https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L137-L140
3)
Check , effect and interact patternis not followed below. State is updated after making an external call.https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L394_L401
4) Event is missing
indexedfieldshttps://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L94_L98
https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L102_L105
5)
TYPOSshould be resolved, to avoid confusion and enhance readability(https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L292)[https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L295](https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L295)[https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L296](https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L296)[https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L411](https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L411)[https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L412](https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L412)[https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L453](https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L453)[https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L485](https://github.com/code-423n4/2022-10-paladin/blob/main/contracts/WardenPledge.sol#L485)
The text was updated successfully, but these errors were encountered: