The fee parameters are all messed up when setting operation

[code423n4]

Lines of code

https://github.com/code-423n4/2022-10-traderjoe/blob/79f25d48b907f9d0379dd803fc2abc9c5f57db93/src/LBPair.sol#L915

Vulnerability details

Impact

The '_setFeesParameters' function of LBPair.sol is not properly implemented, the static and dynamic fee parameters are overlapped due to missing of 114 bits shift for dynamic parameters. It will messes up the parameters and make the LBPair contract unavailable。

Proof of Concept

https://github.com/code-423n4/2022-10-traderjoe/blob/79f25d48b907f9d0379dd803fc2abc9c5f57db93/src/LBPair.sol#L915

Tools Used

VS Code

Recommended Mitigation Steps

    function _setFeesParameters(bytes32 _packedFeeParameters) internal {
        // ...
        assembly {
            sstore(_feeParameters.slot, or(_newFeeParameters, shl(_OFFSET_VARIABLE_FEE_PARAMETERS, _varParameters)))
        }
    }

[trust1995]

Dup of #425

[GalloDaSballo]

Definitely would have liked to see a quick coded POC here

[GalloDaSballo]

Dup of #384

[c4-judge]

GalloDaSballo marked the issue as not a duplicate

[c4-judge]

GalloDaSballo marked the issue as duplicate of #384

[Simon-Busch]

Marked this issue as satisfactory as requested by @GalloDaSballo