Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A recommendation here is to stop using transfer() in the codes and switch to using call() instead. #238

Closed
code423n4 opened this issue Nov 10, 2022 · 3 comments
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate-369 partial-50

Comments

@code423n4
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2022-11-debtdao/blob/update-readme/contracts/utils/LineLib.sol#L48

Vulnerability details

Impact

Transfer() has typically been recommended by the security community because it helps guard against reentrancy attacks. Any smart contract that uses transfer() or send() is taking a hard dependency on gas costs by forwarding a fixed amount of gas: 2300. It works under the assumption that gas costs wouldn’t change, but that assumption turned out to be incorrect since the Istanbul hard fork. As a result, the transfer() functions may fail frequently due to limited gas.

Proof of Concept

https://github.com/code-423n4/2022-11-debtdao/blob/update-readme/contracts/utils/LineLib.sol#L48

Tools Used

Recommended Mitigation Steps

Now it is recommended to stop using transfer() and switch to using call() instead.

@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Nov 10, 2022
code423n4 added a commit that referenced this issue Nov 10, 2022
@c4-judge
Copy link
Contributor

dmvt marked the issue as duplicate of #14

@c4-judge
Copy link
Contributor

dmvt marked the issue as partial-50

@C4-Staff
Copy link
Contributor

liveactionllama marked the issue as duplicate of #369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate-369 partial-50
Projects
None yet
Development

No branches or pull requests

3 participants