Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #173

Open
code423n4 opened this issue Nov 13, 2022 · 4 comments
Open

QA Report #173

code423n4 opened this issue Nov 13, 2022 · 4 comments
Labels
bug Something isn't working grade-a judge review requested Judge should review this issue Q-30 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

See the markdown file with the details of this report here.
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Nov 13, 2022
code423n4 added a commit that referenced this issue Nov 13, 2022
@code423n4
IllIllI issue #173
096543f
code423n4 added a commit that referenced this issue Nov 13, 2022
@code423n4
IllIllI data for issue #173
8f43049
@c4-judge
Copy link
Contributor

Picodes marked the issue as grade-b

@c4-judge
Copy link
Contributor

Picodes marked the issue as grade-a

@c4-judge c4-judge added grade-a and removed grade-b labels Nov 21, 2022
@0xhiroshi
Copy link

L-01 - invalid for LooksRareAggregator and actually valid for SeaportProxy (I know I mentioned it's invalid before)
L-02 - invalid
L-03 - addressed in other issues
N-01 - valid
N-02 - not sure what the problem is exactly
N-03 - invalid, addressed in other issues
N-04 - invalid
N-05 - valid
N-06 - invalid, they are general libs
N-07 - invalid
N-08 - invalid
N-09 - invalid, addressed elsewhere

@c4-sponsor
Copy link

0xhiroshi requested judge review

@c4-sponsor c4-sponsor added the judge review requested Judge should review this issue label Nov 25, 2022
@c4-judge c4-judge mentioned this issue Dec 11, 2022
Closed
@C4-Staff C4-Staff added the Q-30 label Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working grade-a judge review requested Judge should review this issue Q-30 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@code423n4 @0xhiroshi @c4-judge @c4-sponsor @C4-Staff