Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #44

Open
code423n4 opened this issue Nov 10, 2022 · 5 comments
Open

QA Report #44

code423n4 opened this issue Nov 10, 2022 · 5 comments
Labels
bug Something isn't working edited-by-warden grade-b judge review requested Judge should review this issue Q-05 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue

Comments

@code423n4
Copy link
Contributor

See the markdown file with the details of this report here.
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Nov 10, 2022
code423n4 added a commit that referenced this issue Nov 10, 2022
@code423n4
datapunk issue #44
9e9c346
code423n4 added a commit that referenced this issue Nov 10, 2022
@code423n4
datapunk data for issue #44
6bf2080
code423n4 added a commit that referenced this issue Nov 12, 2022
@code423n4
Report for issue #44 updated by datapunk
3aca6db
code423n4 added a commit that referenced this issue Nov 12, 2022
@code423n4
Report for issue #44 updated by datapunk
3bc14d5
code423n4 added a commit that referenced this issue Nov 12, 2022
@code423n4
Report for issue #44 updated by datapunk
a3a6f2c
code423n4 added a commit that referenced this issue Nov 12, 2022
@code423n4
Report for issue #44 updated by datapunk
72bb6bf
code423n4 added a commit that referenced this issue Nov 13, 2022
@code423n4
Report for issue #44 updated by datapunk
fbe0e69
@c4-judge c4-judge mentioned this issue Nov 21, 2022
Closed
@c4-judge
Copy link
Contributor

Picodes marked the issue as grade-b

@0xhiroshi
Copy link

QA1: Invalid, it is highly unlikely for us to see NFTs traded on the aggregator worth less than 0.001 ETH (1e15) so realistically we won't lose precision.
QA2: Valid
QA3: We just won't bother with rescuing fake tokens.
QA4: We already have a fee slippage.

@c4-sponsor c4-sponsor added the sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue label Nov 23, 2022
@c4-sponsor
Copy link

0xhiroshi marked the issue as sponsor disputed

@c4-sponsor c4-sponsor added the judge review requested Judge should review this issue label Nov 23, 2022
@c4-sponsor
Copy link

0xhiroshi requested judge review

@0xhiroshi
Copy link

@Picodes what is the edict of this report?

@C4-Staff C4-Staff added the Q-05 label Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working edited-by-warden grade-b judge review requested Judge should review this issue Q-05 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@code423n4 @0xhiroshi @c4-judge @c4-sponsor @C4-Staff