Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #49

Open
code423n4 opened this issue Nov 10, 2022 · 3 comments
Open

QA Report #49

code423n4 opened this issue Nov 10, 2022 · 3 comments
Labels
bug Something isn't working grade-a judge review requested Judge should review this issue Q-07 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

See the markdown file with the details of this report here.
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Nov 10, 2022
code423n4 added a commit that referenced this issue Nov 10, 2022
@code423n4
fatherOfBlocks issue #49
cb834dd
code423n4 added a commit that referenced this issue Nov 10, 2022
@code423n4
fatherOfBlocks data for issue #49
dffa3bc
@c4-judge
Copy link
Contributor

Picodes marked the issue as grade-a

@0xhiroshi
Copy link

IProxy

  • Valid

SeaportInterface/ConsiderationStructs

  • Won't fix, we copied the files from Seaport.

LooksRareProxy

  • Invalid, we won't provide 0 address.
  • Valid for unused interfaces

SeaportProxy

  • Valid for unused interfaces
  • Invalid, we won't provide 0 address.
  • Valid for _transferFee

ERC20EnabledLooksRareAggregator

  • Invalid, we won't provide 0 address.

LooksRareAggregator

  • Valid for imports
  • Invalid for setERC20EnabledLooksRareAggregator

TokenTransfer

  • Valid

@c4-sponsor
Copy link

0xhiroshi requested judge review

@c4-sponsor c4-sponsor added the judge review requested Judge should review this issue label Nov 23, 2022
@C4-Staff C4-Staff added the Q-07 label Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working grade-a judge review requested Judge should review this issue Q-07 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@code423n4 @0xhiroshi @c4-judge @c4-sponsor @C4-Staff