Skip to content

Commit

Permalink
Report for issue #209 updated by Josiah
Browse files Browse the repository at this point in the history
  • Loading branch information
code423n4 committed Nov 14, 2022
1 parent 6ac6375 commit 808c689
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions data/Josiah-Q.md
Expand Up @@ -262,4 +262,11 @@ Here is one instance found.
}
}
```
## MSG.SENDER WITH MULTIPLE ADDRESSES
In `transferFrom()` of `Pool.sol`, the if statement is comparing `msg.sender` with `EXCHANGE` and `SWAP` whose addresses have been set to the same address. However, this will make the function call always reverting when both `EXCHANGE` and `SWAP` are assigned a different address as indicated in the [TODO](https://github.com/code-423n4/2022-11-non-fungible/blob/main/contracts/Pool.sol#L18).

[Pool.sol#L62](https://github.com/code-423n4/2022-11-non-fungible/blob/main/contracts/Pool.sol#L62) should therefore be refactored as follows by having `&&` replaced with `||`:

```
if (msg.sender != EXCHANGE || msg.sender != SWAP) {
```

0 comments on commit 808c689

Please sign in to comment.