# [M-01] Usage of deprecated sendValue to send eth

[code423n4]

Lines of code

https://github.com/code-423n4/2022-11-paraspace/blob/main/paraspace-core/contracts/protocol/libraries/logic/LiquidationLogic.sol#L875
https://github.com/code-423n4/2022-11-paraspace/blob/main/paraspace-core/contracts/protocol/libraries/logic/MarketplaceLogic.sol#L571

Vulnerability details

Impact

The recommended way to send ether is with call function. Using transfer or sendValue could lead to running out of gas, due to the fact that it is predefined and the transfer will fail, in such scenario there won't be way to withraw the amount from the contract.

Proof of Concept

875: Address.sendValue(

571: Address.sendValue(payable(msg.sender), ethLeft);

Tools Used

Manual audit

Recommended Migration Steps

The recommended way to send ether is with call function. Using transfer or sendValue could lead to running out of gas, due to the fact that it is predefined and the transfer will fail, in such scenario there won't be way to withraw the amount from the contract.

[c4-judge]

dmvt marked the issue as primary issue

[c4-judge]

Duplicate of #69