returning wrong information for AccumulatedETH in GiantMevAndFeesPool.sol

[code423n4]

Lines of code

https://github.com/code-423n4/2022-11-stakehouse/blob/4b6828e9c807f2f7c569e6d721ca1289f7cf7112/contracts/liquid-staking/GiantMevAndFeesPool.sol#L91

Vulnerability details

Impact

The function is not used internally from any other contract, but can/will be used from bots or endusers to check the balance.
As the return value is always wrong when _stakingFundsVaults.length > 1 it is not usable for consumers.

Proof of Concept

accumulated is overwritten for every loop.

File: contracts/liquid-staking/GiantMevAndFeesPool.sol
89:         uint256 accumulated;
90:         for (uint256 i; i < _stakingFundsVaults.length; ++i) {
91:             accumulated = StakingFundsVault(payable(_stakingFundsVaults[i])).batchPreviewAccumulatedETH(
92:                 address(this),
93:                 _lpTokens[i]
94:             );
95:         }

In the end accumulated is returned via

return _previewAccumulatedETH(_user, address(_lpTokenETH), _lpTokenETH.balanceOf(_user), _lpTokenETH.totalSupply(), accumulated);

Recommended Mitigation Steps

Remove function, so users or bots can't use it if it's not important, or fix the accumulated to sum up correctly.

accumulated +=

[c4-judge]

dmvt marked the issue as duplicate of #160

[c4-judge]

dmvt marked the issue as satisfactory