QA Report

[code423n4]

See the markdown file with the details of this report here.

[GalloDaSballo]

L-1 The recordStakingEnd() function does not match the documentation exactly Low 1
L

L-2 getMinipools() function may unexpectedly revert Low 1
R

L-3 getStakers() function may unexpectedly revert Low 1
R

L-4 "Dirty hack" Low 3
Invalid, for lack of proof

NC-1 Open TODOs Non-Critical 3
NC

NC-2 Order of Functions Non-Critical 13
NC

NC-3 Order of Layout Non-Critical 7
NC

NC-4 Empty function body Non-Critical 1
Nc

NC-5 Typos in event names Non-Critical 3
NC

NC-6 Typos in comments Non-Critical 22
NC

NC-7 Missing NatSpec Non-Critical 16
NC

NC-8 Unused named return variables Non-Critical 2
R

NC-9 Maximum line length exceeded Non-Critical 25
NC

NC-10 Use Checks Effects Interactions pattern Non-Critical 1
L

NC-11 Code can be made more consistent Non-Critical 1
R

NC-12 Move the function for clarity
NC

[GalloDaSballo]

2L 4R 9NC

[c4-judge]

GalloDaSballo marked the issue as grade-b